On 03/03/2015 03:18 PM, Eric Dumazet wrote: > On Tue, 2015-03-03 at 14:53 +0100, Nicolas Schichan wrote: >> On 03/03/2015 02:42 PM, Eric Dumazet wrote: >>>> To avoid that, I would take priv->tx_lock only once, or add a limit on >>>> the number of skbs that can be drained per round. >>> >>> Something like this (untested) patch >> >> I'm not against testing this patch, but we do not have any SMP capable >> bcm63xx >> board here so I don't think it will be of any use. >> >> bcm6358 and bcm6368 do indeed have two MIPS threads, but SMP is not possible >> (due to a data cache or TLB shared across all MIPS threads , unbearably >> complicating things, IIRC). >> >> bcm63xx ARM SoCs look like they can support SMP though. >> >> Regards, >> > > I am reasonably confident the patch is OK, but I cannot easily compile > it on my laptop (x86_64) :
Okay, I gave your patch a go and it works correctly on our non-SMP capable boards (and with DEBUG_SPINLOCK=y). Feel free to add: Tested-by: Nicolas Schichan <nschic...@freebox.fr> Regards, -- Nicolas Schichan Freebox SAS -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
