On Fri, Jul 15, 2005 at 01:56:29AM -0700, Andrew Morton wrote: > Russell King <[EMAIL PROTECTED]> wrote: > > > > On Fri, Jul 15, 2005 at 01:36:53AM -0700, Andrew Morton wrote: > > > +uart_handle_sysrq_char-warning-fix.patch > > > > > > Fix a warning > > > > Andrew, this requires a little more fixing than your simple patch. > > Several drivers omit 'regs' from the receive handler when sysrq is > > not enabled. Hence, this simple fix on its own will cause compile > > failures. > > Me no understand. It replaces a three-arg macro with a three-arg static > inline?
Some serial drivers drop 'regs' from the parent function when sysrq is disabled. 'regs' is only passed for sysrq support. (Yes, it's disgusting, but I thought at the time I had the choice of being lynched by the "as efficient as possible" mob, or...) -- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: 2.6 Serial core - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
