2015-02-24 21:47 GMT+08:00 Kishon Vijay Abraham I <[email protected]>: > Hi, > > On Tuesday 24 February 2015 05:22 PM, Axel Lin wrote: >> >> Currently, of_get_child_count() is called in each iteration of the for >> loop in >> miphy28lp_xlate(). This patch stores the return value of >> of_get_child_count() >> in miphy_dev->nphys and call of_get_child_count() once in >> miphy28lp_probe(). >> >> Signed-off-by: Axel Lin <[email protected]> >> --- >> drivers/phy/phy-miphy28lp.c | 11 ++++++----- >> 1 file changed, 6 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/phy/phy-miphy28lp.c b/drivers/phy/phy-miphy28lp.c >> index 9b2848e..d444932 100644 >> --- a/drivers/phy/phy-miphy28lp.c >> +++ b/drivers/phy/phy-miphy28lp.c >> @@ -228,6 +228,7 @@ struct miphy28lp_dev { >> struct regmap *regmap; >> struct mutex miphy_mutex; >> struct miphy28lp_phy **phys; >> + int nphys; > > > it can just be a local member to miphy28lp_xlate() since it's not used > anywhere else.
It's used in both miphy28lp_probe() and miphy28lp_xlate(). miphy_dev->phys replaces the chancount local variable as well. Regards, Axel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
