On Thu, Feb 12, 2015 at 6:33 PM, nick <xerofo...@gmail.com> wrote: > Greets to Everyone, > I am wondering after running sparse on the latest mainline tree why we are > not unlocking the spinlock_bh,lock when calling the function, > gnet_stats_start_copy_compat at the end of this function's body. Unless > someone can explain to me why there is a very good reason for not > unlocking the spinlock_bh,lock at the end of this function I will send in a > patch fixing this. I am assuming this is a bug due to us infinitely > looping in the spinlock_bh and deadlocking unless we exit this lock external > to the call to the function,gnet_start_copy_compat.
The last time I looked at this, there is some place calling unlock, you need to find it out. I don't think anyone touched it ever since that time. Let me know if you still can't find it. And yes, that code is kinda messy, I _do_ have a patch to clean it up (not sent out yet). -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
