Hi Greg,
Please include this patch and the following one for sysfs. This is needed
after the introduction of sysfs setattr functionality.
Thanks
Maneesh
o sysfs_chmod_file() must update the new iattr field in sysfs_dirent else
the mode change will not be persistent in case of inode evacuation from
cache.
Signed-off-by: Maneesh Soni <[EMAIL PROTECTED]>
---
linux-2.6.13-rc2-maneesh/fs/sysfs/file.c | 18 ++++++++++--------
1 files changed, 10 insertions(+), 8 deletions(-)
diff -puN fs/sysfs/file.c~fix-sysfs_chmod_file fs/sysfs/file.c
--- linux-2.6.13-rc2/fs/sysfs/file.c~fix-sysfs_chmod_file 2005-07-12
11:43:26.799678624 +0530
+++ linux-2.6.13-rc2-maneesh/fs/sysfs/file.c 2005-07-12 11:44:09.213230784
+0530
@@ -440,8 +440,8 @@ int sysfs_chmod_file(struct kobject *kob
{
struct dentry *dir = kobj->dentry;
struct dentry *victim;
- struct sysfs_dirent *sd;
- umode_t umode = (mode & S_IALLUGO) | S_IFREG;
+ struct inode * inode;
+ struct iattr newattrs;
int res = -ENOENT;
down(&dir->d_inode->i_sem);
@@ -449,13 +449,15 @@ int sysfs_chmod_file(struct kobject *kob
if (!IS_ERR(victim)) {
if (victim->d_inode &&
(victim->d_parent->d_inode == dir->d_inode)) {
- sd = victim->d_fsdata;
- attr->mode = mode;
- sd->s_mode = umode;
- victim->d_inode->i_mode = umode;
- dput(victim);
- res = 0;
+ inode = victim->d_inode;
+ down(&inode->i_sem);
+ newattrs.ia_mode = (mode & S_IALLUGO) |
+ (inode->i_mode & ~S_IALLUGO);
+ newattrs.ia_valid = ATTR_MODE | ATTR_CTIME;
+ res = notify_change(victim, &newattrs);
+ up(&inode->i_sem);
}
+ dput(victim);
}
up(&dir->d_inode->i_sem);
_
--
Maneesh Soni
Linux Technology Center,
IBM India Software Labs,
Bangalore, India
email: [EMAIL PROTECTED]
Phone: 91-80-25044990
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
