3.16.7-ckt6 -stable review patch.  If anyone has any objections, please let me 
know.

------------------

From: Keerthy <j-keer...@ti.com>

commit c4cf0935a2d8fe6d186bf4253ea3c4b4a8a8a710 upstream.

Correct returning IRQ_HANDLED unconditionally in the irq handler.
Return IRQ_NONE for some interrupt which we do not expect to be
handled in this handler. This prevents kernel stalling with back
to back spurious interrupts.

Fixes: 2722e56de6 ("OMAP4: l3: Introduce l3-interconnect error handling driver")
Acked-by: Nishanth Menon <n...@ti.com>
Signed-off-by: Keerthy <j-keer...@ti.com>
Signed-off-by: Tony Lindgren <t...@atomide.com>
Signed-off-by: Luis Henriques <luis.henriq...@canonical.com>
---
 drivers/bus/omap_l3_noc.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/bus/omap_l3_noc.c b/drivers/bus/omap_l3_noc.c
index b5eac29d8f6e..17d86595951c 100644
--- a/drivers/bus/omap_l3_noc.c
+++ b/drivers/bus/omap_l3_noc.c
@@ -222,10 +222,14 @@ static irqreturn_t l3_interrupt_handler(int irq, void 
*_l3)
                        }
 
                        /* Error found so break the for loop */
-                       break;
+                       return IRQ_HANDLED;
                }
        }
-       return IRQ_HANDLED;
+
+       dev_err(l3->dev, "L3 %s IRQ not handled!!\n",
+               inttype ? "debug" : "application");
+
+       return IRQ_NONE;
 }
 
 static const struct of_device_id l3_noc_match[] = {
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to