> Patch is generally fine, thanks for addressing my comments. Prior to merging I > always run checkpatch.pl just in case I missed anything obvious: > > $ scripts/checkpatch.pl ~/samsung/01-lid-handling.patch > WARNING: Prefer kstrto<type> to single variable sscanf > #219: FILE: drivers/platform/x86/samsung-laptop.c:900: > + if (!count || sscanf(buf, "%i", &value) != 1) > + return -EINVAL; > > total: 0 errors, 1 warnings, 219 lines checked > > Please always run checkpatch.pl. It isn't sufficient and doesn't catch > everything, but it is a minimum bar kind of thing.
I did run checkpatch.pl but left sscanf to be consistent with set_battery_life_extender and set_usb_charge functions. Nevertheless, I have just sent the third version of the patch with sscanf changed to kstrtoint. Thank you. Julijonas -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
