Remove the three get_mm_counter(mm, rss) tests from rmap.c: there was a time when testing rss was important to avoid a particular race between dup_mmap and the anonmm rmap; but now it's just a rather silly pseudo- optimization, made even more obscure by the get_mm_counter macro.
Signed-off-by: Hugh Dickins <[EMAIL PROTECTED]> --- mm/rmap.c | 7 +------ 1 files changed, 1 insertion(+), 6 deletions(-) --- 2.6.13-rc2-mm1/mm/rmap.c 2005-07-07 12:33:21.000000000 +0100 +++ linux/mm/rmap.c 2005-07-09 01:20:41.000000000 +0100 @@ -290,8 +290,6 @@ static int page_referenced_one(struct pa pte_t *pte; int referenced = 0; - if (!get_mm_counter(mm, rss)) - goto out; address = vma_address(page, vma); if (address == -EFAULT) goto out; @@ -522,8 +520,6 @@ static int try_to_unmap_one(struct page pte_t pteval; int ret = SWAP_AGAIN; - if (!get_mm_counter(mm, rss)) - goto out; address = vma_address(page, vma); if (address == -EFAULT) goto out; @@ -771,8 +767,7 @@ static int try_to_unmap_file(struct page if (vma->vm_flags & (VM_LOCKED|VM_RESERVED)) continue; cursor = (unsigned long) vma->vm_private_data; - while (get_mm_counter(vma->vm_mm, rss) && - cursor < max_nl_cursor && + while ( cursor < max_nl_cursor && cursor < vma->vm_end - vma->vm_start) { try_to_unmap_cluster(cursor, &mapcount, vma); cursor += CLUSTER_SIZE; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/