Hi Sergei, Thank you for your review.
> -----Original Message----- > From: Sergei Shtylyov [mailto:sergei.shtyl...@cogentembedded.com] > Sent: Wednesday, January 28, 2015 6:09 PM > To: Yang, Wenyou; Ferre, Nicolas; li...@arm.linux.org.uk > Cc: linux-arm-ker...@lists.infradead.org; linux-kernel@vger.kernel.org; > alexandre.bell...@free-electrons.com; sylvain.roc...@finsecur.com; > p...@axentia.se; li...@maxim.org.za > Subject: Re: [PATCH v2 3/3] pm: at91: add disable/enable the L1/L2 cache while > suspend/resume > > Hello. > > On 1/28/2015 5:24 AM, Wenyou Yang wrote: > > > For the sama5, disable L1 D-cache and L2 cache before the cpu go to > > wfi, after wakeing up, enable L1 D-cache and L2 cache. > > Waking. > > > Signed-off-by: Wenyou Yang <wenyou.y...@atmel.com> > > --- > > arch/arm/mach-at91/pm.c | 12 +++++ > > arch/arm/mach-at91/pm_suspend.S | 107 > +++++++++++++++++++++++++++++++++++++++ > > 2 files changed, 119 insertions(+) > > [...] > > diff --git a/arch/arm/mach-at91/pm_suspend.S > > b/arch/arm/mach-at91/pm_suspend.S index 311cc23..02d4e56 100644 > > --- a/arch/arm/mach-at91/pm_suspend.S > > +++ b/arch/arm/mach-at91/pm_suspend.S > [...] > > @@ -324,3 +325,109 @@ ram_restored: > [...] > > +l2x_sync: > > I don't see where this label is used. I thought it is an indication the following is for L2 cache synchronization. It is redundant, remove it. > > > + ldr r0, [r2, #L2X0_CACHE_SYNC] > > + bic r0, r0, #0x1 > > + str r0, [r2, #L2X0_CACHE_SYNC] > > +sync: > > + ldr r0, [r2, #L2X0_CACHE_SYNC] > > + ands r0, r0, #0x1 > > + bne sync > > + > > +skip_l2disable: > > + ldmfd sp!, {r4 - r12, pc} > > +ENDPROC(at91_disable_l1_l2_cache) > [...] > > WBR, Sergei Best Regards, Wenyou Yang -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
