Hi, On Fri, 8 Jul 2005, Pekka J Enberg wrote:
> On Fri, 8 Jul 2005, Pekka Enberg wrote: > > > > +#define PNODE_MEMBER_VFS 0x01 > > > > +#define PNODE_SLAVE_VFS 0x02 > > > > Enums, please. > > Roman Zippel writes: > > Is this becoming a requirement now? I personally would rather leave that to > > personal preference... > > Hey, I just review patches. I don't get to set requirements. There's a reason > why enums are preferred though. They define a proper name for the constant. Who prefers that? > It's far to easy to mess up with #defines. Rather unlikely with such simple masks. > They also document the code intent > much better as you can group related constants together. You can't do that with defines? bye, Roman - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
