On 13/01/15 18:14, Sudip Mukherjee wrote:
> var->yoffset is of the type __u32, hence the comparison will always
> be false.
>
> Signed-off-by: Sudip Mukherjee <su...@vectorindia.org>
> ---
> drivers/video/fbdev/hgafb.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/hgafb.c b/drivers/video/fbdev/hgafb.c
> index 5ff9fe2..15d3ccf 100644
> --- a/drivers/video/fbdev/hgafb.c
> +++ b/drivers/video/fbdev/hgafb.c
> @@ -417,8 +417,7 @@ static int hgafb_pan_display(struct fb_var_screeninfo
> *var,
> struct fb_info *info)
> {
> if (var->vmode & FB_VMODE_YWRAP) {
> - if (var->yoffset < 0 ||
> - var->yoffset >= info->var.yres_virtual ||
> + if (var->yoffset >= info->var.yres_virtual ||
> var->xoffset)
> return -EINVAL;
> } else {
> Thanks, queued for 3.20. Tomi
signature.asc
Description: OpenPGP digital signature
