> > case CLOCK_EVT_MODE_RESUME:
> > return dev->setup_resume(dev);
>
> Because setting to all these existing modes isn't allowed
> to fail currently, shouldn't we make return type of all the new
> callbacks as 'void' and return 0 from this routine ? That way, these
> callbacks would stay consistent with the set_mode() callback..
If we go to individual callbacks then we analyze of a case by case
basis which ones need a return value and which ones to not.
> > That gives us a clear distinction of required and optional callbacks,
> > which will make error handling and recovery simpler as well.
>
> Now that we are looking forward to providing individual callbacks
> per feature, I wanted to propose few more solutions to it, though I am
> quite sure you would have already considered and rejected them.
>
> I remember from your earlier mail that you didn't wanted to add
> ONESHOT_STOPPED as a feature (as it isn't a feature really)
> and that restricts us from doing this:
>
> static int __clockevents_set_mode(dev, mode)
> {
> if ((mode == CLOCK_EVT_MODE_ONESHOT_STOPPED) &&
> !(dev->features & CLOCK_EVT_FEAT_ONESHOT_STOPPED))
> return -ENOSYS;
>
> dev->set_mode(mode, dev);
> return 0;
> }
>
> But what about providing a separate callback only for ONESHOT_STOPPED
> mode and use set_mode() for everything else ?
And then fixup all drivers which do not have a default clause in their
switch case and add MODE_ONESHOT_STOPPED? And half a year later we do
the same for the next mode. No way.
The current interface is suboptimal and we fix it proper. Period.
Thanks,
tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
