At Thu, 7 Jul 2005 11:39:29 -0700, Greg KH wrote: > > On Thu, Jul 07, 2005 at 11:46:26AM +0200, Takashi Iwai wrote: > > At Wed, 6 Jul 2005 08:51:03 -0700, > > Greg KH wrote: > > > > > > On Wed, Jul 06, 2005 at 08:42:16AM -0700, Linus Torvalds wrote: > > > > > > > > > > > > On Wed, 6 Jul 2005, Eyal Lebedinsky wrote: > > > > > > > > > > CC [M] sound/pci/bt87x.o > > > > > sound/pci/bt87x.c: In function `snd_bt87x_detect_card': > > > > > sound/pci/bt87x.c:807: error: `driver' undeclared (first use in this > > > > > function) > > > > > sound/pci/bt87x.c:807: error: (Each undeclared identifier is reported > > > > > only once > > > > > sound/pci/bt87x.c:807: error: for each function it appears in.) > > > > > sound/pci/bt87x.c: At top level: > > > > > sound/pci/bt87x.c:910: error: `driver' used prior to declaration > > > > > > > > This seems to be a thinko by Greg. That line got changed from > > > > > > > > supported = pci_match_device(snd_bt87x_ids, pci); > > > > > > > > to > > > > > > > > supported = pci_match_device(driver, pci); > > > > > > > > but as far as I can tell it _should_ be > > > > > > > > supported = pci_match_id(snd_bt87x_ids, pci); > > > > > > No, I wanted it to be "driver", but forgot to build the code, sorry. > > > Try the following patch instead: > > > > Well, I don't think pci_match_device() makes sense here. > > snd_bt87x_detect_card() checks the sample rate of a known device > > (listed in the static pci id table), and doesn't need to check the > > dynamic devices. > > Calling pci_match_id() would be more feasible. > > Ok, that's fine with me if you want to do that instead.
Since Linus already applied the fix patches, I'll leave as it is ;) pci_match_device() should work identically like pci_match_id() in the above case since driver_data is 0. thanks, Takashi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
