On 7/7/05, Christoph Lameter <[EMAIL PROTECTED]> wrote: > On Thu, 7 Jul 2005, Andi Kleen wrote: > > > On Thu, Jul 07, 2005 at 09:21:55AM -0700, Christoph Lameter wrote: > > > On Wed, 6 Jul 2005, Andi Kleen wrote: > > > > > > > Without this patch a dual Xeon EM64T machine would oops on boot > > > > because the hwif pointer here was NULL. I also added a check for > > > > pci_dev because it's doubtful that all IDE devices have pci_devs. > > > > > > Here is IMHO the right way to fix this. Test for the hwif != NULL and > > > test for pci_dev != NULL before determining the node number of the pci > > > bus that the device is connected to. Maybe we need a hwif_to_node for ide > > > drivers that is also able to determine the locality of other hardware? > > > > Hmm? Where is the difference? > > node = -1 if the node cannot be determined. > > > This is 100% equivalent to my code except that you compressed > > it all into a single expression. > > My patch consistently checks for hwif != NULL and pci_dev != NULL. > There was someother stuff in your patch. This patch does not add any > additional variables and is more readable.
seconded but hwif != NULL still just hides some other issue * hwifs and drives are not allocated dynamically * drive->hwif is initialized to hwif for every hwif very early in the driver initialization - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
