Dmitry Torokhov, le Thu 22 Jan 2015 16:37:02 -0800, a écrit : > On Friday, January 23, 2015 01:30:11 AM Samuel Thibault wrote: > > Samuel Thibault, le Fri 23 Jan 2015 01:10:38 +0100, a écrit : > > > Dmitry Torokhov, le Sun 04 Jan 2015 15:28:38 -0800, a écrit : > > > > > + dev = cdev->dev->platform_data; > > > > > > > > Umm, platform data is not the best place for storing this. Why not > > > > drvdata? > > > > > > Ah, actually led_classdev already makes use of it, see the > > > device_create_with_groups call in led_classdev_register. > > > > Actually I'd say it makes sense to be using the platform_data field: > > from the point of view of the led object, the input object is indeed > > something like a platform. > > No, platform data is what difefrentiates an arm board from another arm board, > or an x86 or mips one.
>From the point of view of a device connected to that board, yes. But from the point of view of LEDs connected to a keyboard, the platform is the keyboard. Samuel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
