On Tue, 2015-01-13 at 10:58 +0530, Sanjeev Sharma wrote: > This patch correct the bad expression while writing the > bit-pattern from software's buffer to hardware registers. > > Signed-off-by: Sanjeev Sharma <sanjeev_sha...@mentor.com> > --- > Changes in v2: > - incorporated review comment as per Sergei. > > drivers/net/ethernet/freescale/gianfar_ethtool.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/freescale/gianfar_ethtool.c > b/drivers/net/ethernet/freescale/gianfar_ethtool.c > index 3e1a9c1..347d5ee 100644 > --- a/drivers/net/ethernet/freescale/gianfar_ethtool.c > +++ b/drivers/net/ethernet/freescale/gianfar_ethtool.c > @@ -1586,7 +1586,7 @@ static int gfar_write_filer_table(struct gfar_private > *priv, > return -EBUSY; > > /* Fill regular entries */ > - for (; i < MAX_FILER_IDX - 1 && (tab->fe[i].ctrl | tab->fe[i].ctrl); > + for (; i < MAX_FILER_IDX - 1 && i < tab->fe[i].ctrl); > i++) > gfar_write_filer(priv, i, tab->fe[i].ctrl, tab->fe[i].prop); > /* Fill the rest with fall-troughs */
This makes no sense. Have you tried to compile this ? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
