On 7/4/05, Pekka Enberg <[EMAIL PROTECTED]> wrote:
> Hi Jesper,
>
> On 7/4/05, Jesper Juhl <[EMAIL PROTECTED]> wrote:
> > static int
> > ibm_hdaps_open(struct inode *inode, struct file *filp)
> > {
> > printk("%s() start\n", __func__);
> > if (!atomic_dec_and_test(&ibm_hdaps_available)) {
> > printk("%s() busy\n", __func__);
> > atomic_inc(&ibm_hdaps_available);
> > return -EBUSY;
> > }
> > printk("%s() good\n", __func__);
> >
> > filp->private_data = kmalloc(sizeof(struct hdaps_accel_data),
> > GFP_KERNEL);
>
> You seem to be leaking private_data.
>
Thanks. It still needs a lot of work (as can also be seen from all the
nice feedback in this thread).
I just woke up and I'll start looking at the mails people have posted
in a few hours.
--
Jesper Juhl <[EMAIL PROTECTED]>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
