Hi Nishanth, 2015-01-03 2:43 GMT+09:00 Nishanth Menon <n...@ti.com>: > AM437x generation of processors support programming the PL310 L2Cache > controller's address filter start and end registers using a secure > montior service.
typo: s/montior/monitor/ [snip] > + base = omap4_get_l2cache_base(); > + filter_start = (reg == L310_ADDR_FILTER_START) ? val : > + readl_relaxed(base + L310_ADDR_FILTER_START); > + filter_end = (reg == L310_ADDR_FILTER_END) ? val : > + readl_relaxed(base + L310_ADDR_FILTER_END); > + omap_smc1_2(AM43X_MON_L2X0_SETFILTER_INDEX, filter_start, > + filter_end); > + return; I don't have any significant comments about this patch in particular, but just noticed that you need to do read-backs here (and the typo thanks to the spell checker of my mailing app). Maybe you should consider switching to the .configure() API I introduced in my series? This would let you get rid of the hardcoded static mapping. Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
