On Thursday 01 January 2015 18:55:12 Rickard Strandqvist wrote:
> Removes some functions that are not used anywhere:
> ecard_disablefiq() ecard_enablefiq()
>
> This was partially found by using a static code analysis program called
> cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqv...@spectrumdigital.se>
Looks like a correct change to me, very nice!
However looking a bit further you will notice that after this is removed,
there is more that becomes unused:
> -void ecard_enablefiq(unsigned int fiqnr)
> -{
> - ecard_t *ec = slot_to_ecard(fiqnr);
> -
> - if (ec) {
> - if (!ec->ops)
> - ec->ops = &ecard_default_ops;
> -
> - if (ec->claimed && ec->ops->fiqenable)
> - ec->ops->fiqenable(ec, fiqnr);
> - else
> - printk(KERN_ERR "ecard: rejecting request to "
> - "enable FIQs for %d\n", fiqnr);
> - }
> -}
> -
> -void ecard_disablefiq(unsigned int fiqnr)
> -{
> - ecard_t *ec = slot_to_ecard(fiqnr);
> -
> - if (ec) {
> - if (!ec->ops)
> - ec->ops = &ecard_default_ops;
> -
> - if (ec->ops->fiqdisable)
> - ec->ops->fiqdisable(ec, fiqnr);
> - }
> -}
These are in fact the only references to the fiqenable/fiqdisable/fiqpending
callback pointers, so it would be helpful to remove them as well, along with
the stub implementation from
Is cppcheck something you are working on yourself, or did you pick it up
from someone else? Is it possible to get cppcheck to also find those unused
callback pointers? I assume we have more of them in other code.
Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
