On Tue, Dec 23, 2014 at 10:41 PM, kbuild test robot
<fengguang...@intel.com> wrote:
> net/openvswitch/vport-gre.c:188:5-11: inconsistent IS_ERR and PTR_ERR,
> PTR_ERR on line 189
>
> PTR_ERR should access the value just tested by IS_ERR
>
> Semantic patch information:
> There can be false positives in the patch case, where it is the call
> IS_ERR that is wrong.
>
> Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci
>
> CC: Pravin B Shelar <pshe...@nicira.com>
> Signed-off-by: Fengguang Wu <fengguang...@intel.com>
Thanks for the fix.
Acked-by: Pravin B Shelar <pshe...@nicira.com>
> ---
>
> vport-gre.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/net/openvswitch/vport-gre.c
> +++ b/net/openvswitch/vport-gre.c
> @@ -186,7 +186,7 @@ static int gre_tnl_send(struct vport *vp
> /* Push Tunnel header. */
> skb = __build_header(skb, tunnel_hlen);
> if (IS_ERR(skb)) {
> - err = PTR_ERR(rt);
> + err = PTR_ERR(skb);
> skb = NULL;
> goto err_free_rt;
> }
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
