Aapo, On Fri, Dec 19, 2014 at 12:37:16PM +0200, Aapo Vienamo wrote: > On Thu, Dec 18, 2014 at 02:45:01PM -0800, Jeremiah Mahler wrote: > > Aapo, > > > > On Thu, Dec 18, 2014 at 05:32:52PM +0200, Aapo Vienamo wrote: > > > This patch fixes a coding style issue found by the checkpatch.pl tool in > > > amplc_dio200_common.c by removing the unnecessary parentheses around the > > > expression in a return statement. > > > > > > Signed-off-by: Aapo Vienamo <aapo.vien...@iki.fi> > > > --- > > > drivers/staging/comedi/drivers/amplc_dio200_common.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/staging/comedi/drivers/amplc_dio200_common.c > > > b/drivers/staging/comedi/drivers/amplc_dio200_common.c > > > index 26aad70..6eadbbe 100644 > > > --- a/drivers/staging/comedi/drivers/amplc_dio200_common.c > > > +++ b/drivers/staging/comedi/drivers/amplc_dio200_common.c > > > @@ -340,7 +340,7 @@ static int dio200_handle_read_intr(struct > > > comedi_device *dev, > > > > > > comedi_handle_events(dev, s); > > > > > > - return (triggered != 0); > > > + return triggered != 0; > > > } > > > > > [...] > > > > When I run checkpatch.pl it doesn't find any errors and the parenthesis > > haven't been removed. How are you running checkpatch.pl? Are you using > > any extra options? > > It looks like that I accidentally ran the file trough an older version > of checkpatch.pl. The error for this case was quieted in commit > 5b9553a (checkpatch: make "return is not a function" test quieter). > > Sorry for the noise. > > - Aapo Vienamo
If you are looking for something easy to fix have a look in drivers/staging/rtl8192u/ There are lots of checkpatch errors to fix in there. -- - Jeremiah Mahler -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
