On Thu, Dec 18, 2014 at 08:26:52AM +0000, Lee Jones wrote:
> On Wed, 17 Dec 2014, Guenter Roeck wrote:
> > On Wed, Dec 17, 2014 at 04:45:25PM +0000, Lee Jones wrote:
> > > Signed-off-by: David Paris <david.pa...@st.com>
> > > Signed-off-by: Lee Jones <lee.jo...@linaro.org>
> >
> > Hi Lee and David,
> >
> > I still have a couple of comments below. Sorry I didn't catch those earlier.
> >
> > Thanks,
> > Guenter
> >
> > > ---
> > > drivers/watchdog/Kconfig | 13 ++
> > > drivers/watchdog/Makefile | 1 +
> > > drivers/watchdog/st_wdt.c | 323
> > > ++++++++++++++++++++++++++++++++++++++++++++++
> > > 3 files changed, 337 insertions(+)
> > > create mode 100644 drivers/watchdog/st_wdt.c
>
> Chopping all the crud.
>
> [...]
>
> > > +static struct of_device_id st_wdog_match[] = {
> > > + {
> > > + .compatible = "st,stih407-lpc",
> > > + .data = (void *)&stih407_syscfg,
> >
> > Nitpick: typecast to and from void * is not necessary.
>
> Actually that's not true, but it is superfluous in this case.
>
Point taken. Would you agree to a more detailed "typecasting a pointer
to and from void * is not necessary" ?
Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
