On Fri, Apr 15, 2005 at 11:43:55AM +0530, Hariprasad Nellitheertha wrote: > Hi Andi, > > In order to port kdump to x86_64, we need to have the > memmap= kernel command line option available. This is so > that the dump-capture kernel can be booted with a custom > memory map. > > The attached patch adds the memmap= functionality to the > x86_64 kernel. It is against 2.6.12-rc2-mm3. I have done > some amount of testing and it is working fine. > > Could you kindly review this patch and let me know your > thoughts on it.
You should add a __setup somewhere, otherwise the kernel will complain about unknown arguments or generate a memmap variable in inits environment. Comma parsing would be nice. Otherwise it looks ok. -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/