So I should move mclk to wm8960_priv. And doing wm8960_priv->mclk = devm_clk_get(&i2c->dev, "codec_mclk") in wm8960_i2c_probe.
Best Regards, Zidan -----Original Message----- From: Mark Brown [mailto:broo...@kernel.org] Sent: Saturday, December 06, 2014 1:40 AM To: Charles Keepax Cc: Wang Zidan-B50113; lgirdw...@gmail.com; pe...@perex.cz; ti...@suse.de; l...@metafoo.de; Xiubo Li-B47053; patc...@opensource.wolfsonmicro.com; alsa-de...@alsa-project.org; linux-kernel@vger.kernel.org Subject: Re: [alsa-devel][PATCH v3] ASoC: wm8960: Let wm8960 codec driver manage its own MCLK On Fri, Dec 05, 2014 at 05:01:56PM +0000, Charles Keepax wrote: > On Thu, Dec 04, 2014 at 08:41:19PM +0800, Zidan Wang wrote: > > struct wm8960_data { > > + struct clk *mclk; > Is this really pdata? Would the pdata entry to locate the clock not be > a string holding the clock name that you call clk_get on, rather than > a clk pointer itself? Probably this should go in wm8960_priv instead. There should be no platform data of any kind for the clock, the name should be fixed and defined in terms of the name of the clock on the device requesting it. The code is actually doing the right thing here, it's just that it's put the variable into the platform data because currently the driver just uses the platform data as the driver data. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
