On Thu, Dec 04, 2014 at 10:08:15PM +0100, Tom Van Braeckel wrote:
> Place the miscdevice in the file's private_data to be used by the file
> operations.
>
> Previously, this was done only when an open() operation had been registered.
> But it is also useful in the other file operations, so we pass it on
> unconditionally.
>
> Signed-off-by: Tom Van Braeckel <tomvanbraec...@gmail.com>
> ---
> drivers/char/misc.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/char/misc.c b/drivers/char/misc.c
> index ffa97d2..c3681fb 100644
> --- a/drivers/char/misc.c
> +++ b/drivers/char/misc.c
> @@ -140,10 +140,16 @@ static int misc_open(struct inode * inode, struct file
> * file)
> goto fail;
> }
>
> + /*
> + * Place the miscdevice in the file's
> + * private_data so it can be used by the
> + * file operations, including f_op->open below
> + */
> + file->private_data = c;
> +
> err = 0;
> replace_fops(file, new_fops);
> if (file->f_op->open) {
> - file->private_data = c;
> err = file->f_op->open(inode,file);
> }
These braces aren't needed anymore, right?
Also, what is this now going to break? :)
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
