2014-12-03 7:55 GMT+01:00 Takashi Iwai <ti...@suse.de>:
> At Wed, 3 Dec 2014 00:12:55 +0100,
> Rickard Strandqvist wrote:
>>
>> Remove function snd_cmipci_pll_rmn() that is not used anywhere.
>
> It's an experimental code that is currently disabled. Keeping such a
> code would be still meaningful if anyone wants to start a similar
> experiment again.
>
>
> Takashi
>
>> This was partially found by using a static code analysis program called
>> cppcheck.
>>
>> Signed-off-by: Rickard Strandqvist <rickard_strandqv...@spectrumdigital.se>
>> ---
>> sound/pci/cmipci.c | 41 -----------------------------------------
>> 1 file changed, 41 deletions(-)
>>
>> diff --git a/sound/pci/cmipci.c b/sound/pci/cmipci.c
>> index 85ed403..e33edae 100644
>> --- a/sound/pci/cmipci.c
>> +++ b/sound/pci/cmipci.c
>> @@ -615,47 +615,6 @@ static unsigned int snd_cmipci_rate_freq(unsigned int
>> rate)
>>
>> #ifdef USE_VAR48KRATE
>> /*
>> - * Determine PLL values for frequency setup, maybe the CMI8338 (CMI8738???)
>> - * does it this way .. maybe not. Never get any information from C-Media
>> about
>> - * that <wer...@suse.de>.
>> - */
>> -static int snd_cmipci_pll_rmn(unsigned int rate, unsigned int adcmult, int
>> *r, int *m, int *n)
>> -{
>> - unsigned int delta, tolerance;
>> - int xm, xn, xr;
>> -
>> - for (*r = 0; rate < CM_MAXIMUM_RATE/adcmult; *r += (1<<5))
>> - rate <<= 1;
>> - *n = -1;
>> - if (*r > 0xff)
>> - goto out;
>> - tolerance = rate*CM_TOLERANCE_RATE;
>> -
>> - for (xn = (1+2); xn < (0x1f+2); xn++) {
>> - for (xm = (1+2); xm < (0xff+2); xm++) {
>> - xr = ((CM_REFFREQ_XIN/adcmult) * xm) / xn;
>> -
>> - if (xr < rate)
>> - delta = rate - xr;
>> - else
>> - delta = xr - rate;
>> -
>> - /*
>> - * If we found one, remember this,
>> - * and try to find a closer one
>> - */
>> - if (delta < tolerance) {
>> - tolerance = delta;
>> - *m = xm - 2;
>> - *n = xn - 2;
>> - }
>> - }
>> - }
>> -out:
>> - return (*n > -1);
>> -}
>> -
>> -/*
>> * Program pll register bits, I assume that the 8 registers 0xf8 up to 0xff
>> * are mapped onto the 8 ADC/DAC sampling frequency which can be chosen
>> * at the register CM_REG_FUNCTRL1 (0x04).
>> --
>> 1.7.10.4
Hi
Maybe it had been appropriate to add some comment or something then....?
And thanks Bjorn, was a better idea to write like in the patch text.
Kind regards
Rickard Strandqvist
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
