On Tue, Dec 2, 2014 at 7:13 PM, Steven Rostedt <rost...@goodmis.org> wrote: > From: "Steven Rostedt (Red Hat)" <rost...@goodmis.org> > > Add a test to test the event filter logic. It currently tests the > following filters against sched:sched_switch event. > > ( prev_pid != 0 ) > ( prev_pid == 0 ) > ( prev_pid < 100 ) > ( prev_pid <= $$ ) > ( prev_pid > 100 ) > ( prev_pid >= $$ ) > ! ( prev_pid != 0 ) > ! ( prev_pid == 0 ) > ! ( prev_pid < 100 ) > ! ( prev_pid <= $$ ) > ! ( prev_pid > 100 ) > ! ( prev_pid >= $$ ) > ( prev_pid != 0 && next_pid > 10 ) > ( prev_pid != 0 || next_pid > 10 ) > ! ( prev_pid != 0 && next_pid > 10 ) > ! ( prev_pid != 0 || next_pid > 10 ) > ( prev_pid & 1 ) > ( prev_pid & 2 ) > ( prev_pid & 4 ) > ( prev_pid & 8 ) > ( prev_pid & 16 ) > ! ( prev_pid & 1 ) > ! ( prev_pid & 2 ) > ! ( prev_pid & 4 ) > ! ( prev_pid & 8 ) > ! ( prev_pid & 16 ) > ( next_comm ~ "ftrace-test-fil" ) > ( next_comm != "ftrace-test-fil" ) > ! ( next_comm ~ "ftrace-test-fil" ) > ! ( next_comm != "ftrace-test-fil" )
thanks for the tests! Since you're adding full support for 'not', I think would be good to have few more tests where ! is not a top node. Like: (prev_pid != 0 && !(next_pid & 2)) and another one with ! at multiple levels, like: (prev_pid != 0 && !(next_pid != 2 && !(prev_pid > 3))) ... or reject them during parsing. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
