On Mon, 2014-12-01 at 20:29 -0800, Joe Perches wrote: > The compute_score functions are a bit difficult to read. > > Neaten them a bit to reduce object sizes and make them a > bit more intelligible. > > Return early to avoid indentation and avoid unnecessary > initializations. > > (allyesconfig, but w/ -O2 and no profiling)
hmm... Not sure how you get such large numbers... > > $ size net/ipv[46]/udp.o.* > text data bss dec hex filename > 28680 1184 25 29889 74c1 net/ipv4/udp.o.new > 28756 1184 25 29965 750d net/ipv4/udp.o.old > 17600 1010 2 18612 48b4 net/ipv6/udp.o.new > 17632 1010 2 18644 48d4 net/ipv6/udp.o.old Here I have : # size net/ipv4/udp.o.* text data bss dec hex filename 21989 616 9 22614 5856 net/ipv4/udp.o.old 21957 616 9 22582 5836 net/ipv4/udp.o.new With CONFIG_CC_OPTIMIZE_FOR_SIZE=y I even have an opposite result (code gets bigger after your patch) # size net/ipv4/udp.o.* text data bss dec hex filename 17242 600 9 17851 45bb net/ipv4/udp.o.old 17256 600 9 17865 45c9 net/ipv4/udp.o.new Anyway, your patch looks fine to me, no matter what the code size is. Acked-by: Eric Dumazet <eduma...@google.com> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
