At Sun, 30 Nov 2014 00:55:32 -0800, Joe Perches wrote: > > On Sun, 2014-11-30 at 09:41 +0100, Takashi Iwai wrote: > > At Sat, 29 Nov 2014 12:58:12 -0800, > > Joe Perches wrote: > > > > > > There's an enum defined for these magic numbers, > > > might as well use it. > > > > > > Miscellanea: > > > o Use ##__VA_ARGS__ > > > > > > Signed-off-by: Joe Perches <j...@perches.com> > > > > Any specific reason to hang to an irrelevant thread? > > Not in particular, I just noticed it there. > > > Also... > > > > diff --git a/include/sound/core.h b/include/sound/core.h > [] > > > +#define __snd_printk(snd_level, file, line, format, ...) \ > > > + printk(format, ##__VA_ARGS__) > > > > It's better to keep the argument name "level". Using both the same > > name for a variable and its enum type is rather confusing, and just > > gives unnecessary LOCs. > > Write it as you chose. It is pretty trivial.
... trivial for anyone ;) Takashi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
