Hi!

> @@ -0,0 +1,472 @@
> +/*
> + *   LED Flash class driver for the AAT1290
> + *   1.5A Step-Up Current Regulator for Flash LEDs
> + *
> + *   Copyright (C) 2014, Samsung Electronics Co., Ltd.
> + *   Author: Jacek Anaszewski <j.anaszew...@samsung.com>
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License
> + * version 2 as published by the Free Software Foundation.
> + */
> +

> +#define AAT1290_MM_TO_FL_1_92        1
> +#define AAT1290_MM_TO_FL_3_7 2
> +#define AAT1290_MM_TO_FL_5_5 3
> +#define AAT1290_MM_TO_FL_7_3 4
> +#define AAT1290_MM_TO_FL_9   5
> +#define AAT1290_MM_TO_FL_10_7        6
> +#define AAT1290_MM_TO_FL_12_4        7
> +#define AAT1290_MM_TO_FL_14  8
> +#define AAT1290_MM_TO_FL_15_9        9
> +#define AAT1290_MM_TO_FL_17_5        10
> +#define AAT1290_MM_TO_FL_19_1        11
> +#define AAT1290_MM_TO_FL_20_8        12
> +#define AAT1290_MM_TO_FL_22_4        13
> +#define AAT1290_MM_TO_FL_24  14
> +#define AAT1290_MM_TO_FL_25_6        15
> +#define AAT1290_MM_TO_FL_OFF 16

Only one of these defines is unused.

> +static struct of_device_id aat1290_led_dt_match[] = {

> +     {.compatible = "skyworks,aat1290"},

spaces after { and before } ?

Otherwise looks ok, 

Signed-off-by: Pavel Machek <pa...@ucw.cz>

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) 
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to