On Mon, Nov 24, 2014 at 11:00:29AM -0500, Kan Liang wrote:
> From: Kan Liang <kan.li...@intel.com>
>
> symoff can support both same binaries and different binaries. However,
> the offset may be changed for different binaries. This patch checks the
> buildid of perf.data. If they are from different binaries, print a
> warning to notify the user.
>
> Signed-off-by: Kan Liang <kan.li...@intel.com>
> ---
> tools/perf/builtin-diff.c | 25 +++++++++++++++++++++++++
> tools/perf/util/sort.c | 3 +++
> tools/perf/util/sort.h | 1 +
> 3 files changed, 29 insertions(+)
>
> diff --git a/tools/perf/builtin-diff.c b/tools/perf/builtin-diff.c
> index 03a4001..2a8c17a 100644
> --- a/tools/perf/builtin-diff.c
> +++ b/tools/perf/builtin-diff.c
> @@ -678,6 +678,28 @@ static void data__free(struct data__file *d)
> }
> }
>
> +static void buildid_check(void)
> +{
> + struct dsos *base_k_dsos =
> &data__files[0].session->machines.host.kernel_dsos;
> + struct dsos *base_u_dsos =
> &data__files[0].session->machines.host.user_dsos;
> + struct dsos *k_dsos_tmp, *u_dsos_tmp;
> + struct data__file *d;
> + int i;
> +
> + data__for_each_file_new(i, d) {
> + k_dsos_tmp = &d->session->machines.host.kernel_dsos;
> + u_dsos_tmp = &d->session->machines.host.user_dsos;
> +
> + if (!dsos__build_ids_equal(base_k_dsos, k_dsos_tmp))
> + pr_warning("The perf.data come from different kernel. "
> + "The kernel symbol offset may vary for
> different kernel.\n");
> +
> + if (!dsos__build_ids_equal(base_u_dsos, u_dsos_tmp))
looks like at this time not all dsos on the list have
the buildids read..
I tried to put in here the perf_session__read_build_ids call
but it keeps showing me warning below:
> + pr_warning("The perf.data come from different user
> binary. "
> + "The user space symbol offset may vary for
> different binaries.\n");
for following workload:
[jolsa@krava perf]$ ./perf record ls
...
[ perf record: Woken up 1 times to write data ]
[ perf record: Captured and wrote 0.012 MB perf.data (~540 samples) ]
[jolsa@krava perf]$ ./perf record ls
...
[ perf record: Woken up 1 times to write data ]
[ perf record: Captured and wrote 0.012 MB perf.data (~540 samples) ]
[jolsa@krava perf]$ ./perf diff -s symoff
The perf.data come from different user binary. The user space symbol offset may
vary for different binaries.
# Event 'cycles'
...
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
