Greg KH wrote: > On Sat, Apr 02, 2005 at 02:20:11PM +0200, Rolf Eike Beer wrote: > > Greg KH wrote: > > > ChangeSet 1.2181.16.9, 2005/03/17 13:54:33-08:00, > > > [EMAIL PROTECTED] > > > > > > [PATCH] PCI Hotplug: remove code duplication in > > > drivers/pci/hotplug/ibmphp_pci.c > > > > > > This patch removes some code duplication where if and else have the > > > same code at the beginning and the end of the branch. > > > > Greg, as you correctly pointed out this patch if broken. It could never > > reach the if branch and always uses the else branch. Please drop this one > > and review the patch I sent on March 21th to pcihp-discuss for inclusion. > > It removes much more duplication and handles this case correctly. Sorry, > > it looks like I forgot to CC you. I'll bounce this mail to you. > > Hm, care to send me a patch that backs the old one out? Or just one > that fixes it properly, I can't really revert the old patch, now that > I'm not using bitkeeper :)
Yes, I'll prepare one at the weekend when I have access to my patches again. Mail will be sent out on monday. I'll send you two patches: first one to fix it properly and then one that cleans up a bit more. The second one will do the same things like the patch I forwarded you on April 2nd. It would be nice if you could have a look on this patch in the mean time so you maybe can apply the second one immediately. Eike
pgp8m43YK6z84.pgp
Description: PGP signature
