Hi, pushed this patch too, with amendments.
On Fri, 2014-10-31 at 13:50 -0500, Ben Shelton wrote: > @@ -279,6 +283,7 @@ static int ubifs_create(struct inode *dir, struct dentry > *dentry, umode_t mode, > err = ubifs_jnl_update(c, dir, &dentry->d_name, inode, 0, 0); > if (err) > goto out_cancel; > + > mutex_unlock(&dir_ui->ui_mutex); Removed this junk newline change here and in other similar places. > +size_t ubifs_security_listxattr(struct dentry *d, char *list, size_t > list_size, > + const char *name, size_t name_len, int flags) Made this to be static, renamed to 'security_listxattr()'. > +int ubifs_security_getxattr(struct dentry *d, const char *name, > + void *buffer, size_t size, int flags) Similar: rename + static. > +int ubifs_security_setxattr(struct dentry *d, const char *name, > + const void *value, size_t size, > + int flags, int handler_flags) Similar: rename + static. > +struct xattr_handler ubifs_xattr_security_handler = { Renamed, made static and const too. > +static int ubifs_initxattrs(struct inode *inode, > + const struct xattr *xattr_array, void *fs_info) Renamed to just init_xattrs(), for the consistency reasons, the ones I explained in the review to the patch 2/4. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/