Hi,
Am Dienstag, 4. November 2014, 17:15:32 schrieb Lee Jones:
> Actually there is a better way still:
>
> #ifdef CONFIG_OF && IS_ENABLED(CONFIG_BACKLIGHT_CLASS_DEVICE)
> struct backlight_device *of_find_backlight_by_node(struct device_node
> *node); #else
> static inline struct backlight_device *
> of_find_backlight_by_node(struct device_node *node)
> {
> return NULL;
> }
> #endif
After further looking at the problem, I'm actually not even sure, if my
approach is the best one at all.
The problem I was trying to fix was panel-simple (drivers/gpu/drm/panel/panel-
simple.c) checking for an optional backlight, while not depending on the
backlight-class itself.
As both components do not have a relationship, there exist the possibility of
panel-simply being build into the kernel while the backlight_class is build as
module. So while the IS_ENABLED check would define the prototype, panel-generic
would still miss the function when linking.
Should panel-generic simply depend in the backlight_class instead?
Thanks
Heiko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
