Am 06.11.2014 um 08:51 schrieb Artem Bityutskiy: > On Wed, 2014-10-29 at 13:45 +0100, Richard Weinberger wrote: >> Make it two functions, wl_get_wle() and wl_get_peb(). >> wl_get_peb() works exactly like __wl_get_peb() but wl_get_wle() >> does not call produce_free_peb(). >> While refilling the fastmap user pool we cannot release ubi->wl_lock >> as produce_free_peb() does. >> Hence the fastmap logic uses now wl_get_wle(). >> >> Signed-off-by: Richard Weinberger <rich...@nod.at> > > Please, re-consider naming. > > The convention is that non-static function names start with ubi_wl_*. > Static function names start with _*. > > Also, please add a comment above the functions explaining what it does.
On my TODO list is already a big "enhance comments" item. :) I'll send an updates series soon. Thanks, //richard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
