From: Joe Perches <[email protected]> Date: Tue, 04 Nov 2014 11:33:51 -0800
> On Tue, 2014-11-04 at 20:28 +0100, Fabian Frederick wrote: > > trivia: > >> diff --git a/net/ipv4/esp4.c b/net/ipv4/esp4.c > [] >> @@ -392,8 +392,11 @@ static int esp_input(struct xfrm_state *x, struct >> sk_buff *skb) >> if (elen <= 0) >> goto out; >> >> - if ((err = skb_cow_data(skb, 0, &trailer)) < 0) >> + err = skb_cow_data(skb, 0, &trailer); >> + >> + if (err < 0) >> goto out; > > Generally it's better/more common to use > > foo = bar(); > if (!foo) > [error_handler...] > > without the blank line between the set > and the test. +1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
