[adding paul and richard] On Tue, 2014-11-04 at 11:27 +0100, Miklos Szeredi wrote: > From: Miklos Szeredi <mszer...@suse.cz> > > Audit rules disappear when an inode they watch is evicted from the cache. > This is likely not what we want. > > The guilty commit is "fsnotify: allow marks to not pin inodes in core", > which didn't take into account that audit_tree adds watches with a zero > mask. > > Adding any mask should fix this. > > Fixes: 90b1e7a57880 ("fsnotify: allow marks to not pin inodes in core") > Signed-off-by: Miklos Szeredi <mszer...@suse.cz> > Cc: sta...@vger.kernel.org # 2.6.36+ > --- > kernel/audit_tree.c | 1 + > 1 file changed, 1 insertion(+) > > --- a/kernel/audit_tree.c > +++ b/kernel/audit_tree.c > @@ -154,6 +154,7 @@ static struct audit_chunk *alloc_chunk(i > chunk->owners[i].index = i; > } > fsnotify_init_mark(&chunk->mark, audit_tree_destroy_watch); > + chunk->mark.mask = FS_IN_IGNORED; > return chunk; > } >
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/