On Apr 5, 2005 6:45 AM, Jan Harkes <[EMAIL PROTECTED]> wrote: > On Tue, Apr 05, 2005 at 11:22:06AM +0200, Marcel Holtmann wrote: > > I agree with Dmitry on this point. The IHEX parser should not be inside > > firmware_class.c. What about using keyspan_ihex.[ch] for it? > > That's what I had originally, actually called firmware_ihex.ko, since > the IHEX format parser is not in any way keyspan specific and there are > several usb-serial converters that seem to use the same IHEX->.h trick > which could trivially be modified to use this loader. > > But the compiled parser fairly small (< 2KB) and adding it to the > existing module didn't effectively add any size to the firmware_class > module since things are rounded to a page boundary anyways. >
It is not about the size, it is about source separation. Since it has nothing to do with actualy loading of a BLOB from userspace to kernel space I'd put it into lib/, like crc functions, etc. It does not really have to work with "struct firmware *", "void *data, size_t len" should be just as useable. -- Dmitry - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
