(2014/10/13 13:40), Rusty Russell wrote: >> +/* >> + * MODULE_REF_BASE must be 1, since we use atomic_inc_not_zero() for >> + * recovering refcnt (see try_release_module_ref() ). >> + */ >> +#define MODULE_REF_BASE 1 > > True, but we could use atomic_add_unless() instead, and make this > completely generic, right?
Ah, I got it. You might mean replacing atomic_inc_not_zero() in try_release_module_ref with atomic_add_unless(), then we don't need to make MODULE_REF_BASE=1, is that right? Thank you, -- Masami HIRAMATSU Software Platform Research Dept. Linux Technology Research Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: masami.hiramatsu...@hitachi.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
