On Sat, 2014-10-18 at 00:17 +0530, Balavasu wrote: > This patch fixes the checkpatch.pl issue > WARNING: memcpy(dev->dev_addr, mac, ETH_ALEN);
That is not the actual warning. This is the warning: Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2) How have you made sure that mac can not have odd alignment? Make sure your commit message shows how you know that mac is appropriately aligned. > diff --git a/drivers/staging/octeon/ethernet.c > b/drivers/staging/octeon/ethernet.c [] > @@ -452,7 +452,7 @@ int cvm_oct_common_init(struct net_device *dev) > mac = of_get_mac_address(priv->of_node); > > if (mac) > - memcpy(dev->dev_addr, mac, ETH_ALEN); > + ether_addr_copy(dev->dev_addr, mac); > else > eth_hw_addr_random(dev); > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
