Hi Mark, > -----Original Message----- > From: Mark Brown [mailto:broo...@kernel.org] > Sent: Thursday, October 16, 2014 3:30 PM > To: Yang, Wenyou > Cc: linux-...@vger.kernel.org; linux-kernel@vger.kernel.org; Ferre, Nicolas; > linux- > arm-ker...@lists.infradead.org > Subject: Re: [PATCH] spi/atmel: add support for runtime PM > > On Thu, Oct 16, 2014 at 09:49:20AM +0800, Wenyou Yang wrote: > > > +static int atmel_spi_runtime_resume(struct device *dev) { > > + struct spi_master *master = dev_get_drvdata(dev); > > + struct atmel_spi *as = spi_master_get_devdata(master); > > + > > + pinctrl_pm_select_default_state(dev); > > + clk_prepare_enable(as->clk); > > + > > This looks mostly good but you should check the return value of > clk_prepare_enable() - it can fail. Thanks a lot, I will add it.
Best Regards, Wenyou Yang -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
