On Fri, Oct 10, 2014 at 05:41:17PM -0700, Guenter Roeck wrote: > at91_poweroff_get_wakeup_mode can return a negative error code and should > therefore not return an enum type. Similar, its result should not be > assigned to an enum type. Otherwise, the returned value is never negative, > resulting in a compiler warning and a missed error condition, which in turn > results in writing bad values into a chip register. > > Also fix other compiler warnings which can be easily avoided. > > drivers/power/reset/at91-poweroff.c:74:24: > warning: type qualifiers ignored on function return type > drivers/power/reset/at91-poweroff.c:74:24: > warning: no previous prototype for 'at91_poweroff_get_wakeup_mode' > drivers/power/reset/at91-poweroff.c:83:16: > warning: comparison between signed and unsigned integer expressions > drivers/power/reset/at91-poweroff.c:97:2: > warning: comparison of unsigned expression < 0 is always false > > Cc: Maxime Ripard <maxime.rip...@free-electrons.com> > Cc: Nicolas Ferre <nicolas.fe...@atmel.com> > Signed-off-by: Guenter Roeck <li...@roeck-us.net>
Acked-by: Maxime Ripard <maxime.rip...@free-electrons.com> Thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
signature.asc
Description: Digital signature
