Why should this be in the kernel makefiles? If my_struct is NULL, then the kernel will never reach the if statement.
Well, I think there is probably some arch code that uses 16-bit that might use a null pointer, or at least a struct that starts at the 0 address, which would have problems. I think it would be better to avoid that issue just in case, especially since this optimization does not save anything in the case of properly written code.
A warning might be nice though.
If we could turn off the optimization and add a warning, I would support that. Even if we could only add the warning, then at least people would know.
Cheers, Kyle Moffett
-----BEGIN GEEK CODE BLOCK-----
Version: 3.12
GCM/CS/IT/U d- s++: a18 C++++>$ UB/L/X/*++++(+)>$ P+++(++++)>$
L++++(+++) E W++(+) N+++(++) o? K? w--- O? M++ V? PS+() PE+(-) Y+
PGP+++ t+(+++) 5 X R? tv-(--) b++++(++) DI+ D+ G e->++++$ h!*()>++$ r !y?(-)
------END GEEK CODE BLOCK------
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
