On Wed, Sep 24, 2014 at 11:13:45PM -0400, Elshad Mustafayev wrote:
> Fixed a coding style issue.
>
> Signed-off-by: Elshad Mustafayev <elshad...@gmail.com>
> ---
> kernel/acct.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/kernel/acct.c b/kernel/acct.c
> index b4c667d..ed4cf00 100644
> --- a/kernel/acct.c
> +++ b/kernel/acct.c
> @@ -376,9 +376,8 @@ static comp2_t encode_comp2_t(u64 value)
> if (exp > MAXEXP2) {
> /* Overflow. Return largest representable number instead. */
> return (1ul << (MANTSIZE2+EXPSIZE2-1)) - 1;
> - } else {
> - return (value & (MAXFRACT2>>1)) | (exp << (MANTSIZE2-1));
> }
> + return (value & (MAXFRACT2>>1)) | (exp << (MANTSIZE2-1));
Just what makes the replacement easier to follow?
if (foo)
return bar;
else
return baz;
is no less idiomatic than
if (foo)
return bar;
return baz;
Al, really annoyed by how the words "coding style issue" are getting used as
a magic incantation...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
