* Matt Fleming <m...@console-pimps.org> wrote: > +/* > + * There's no way to return an informative status from this function, > + * because any analysis (and printing of error messages) needs to be > + * done directly at the EFI function call-site. > + * > + * For example, EFI_INVALID_PARAMETER could indicate a bug or maybe we > + * just didn't find any PCI devices, but there's no way to tell outside > + * the context of the call. > + */ > +static void setup_efi_pci(struct boot_params *params)
Btw., do we print proper complaints at the EFI call sites if such failures do happen (and if that failure is unexpected/bad)? If that's a given then your patch looks good to me. Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/