On Thu, Sep 18, 2014 at 07:50:20PM +0400, Vladimir Davydov wrote: > The only reason why this function lives in memcontrol.c is that it > depends on memcg_caches_array_size. However, we can pass the new array > size immediately to it instead of new_id+1 so that it will be free of > any memcontrol.c dependencies. > > So let's move this function to slab_common.c and make it static. > > Signed-off-by: Vladimir Davydov <[email protected]> > Cc: Johannes Weiner <[email protected]> > Cc: Michal Hocko <[email protected]> > Cc: Christoph Lameter <[email protected]>
Looks good. One nit below, but not a show stopper. Acked-by: Johannes Weiner <[email protected]> > @@ -646,11 +646,13 @@ int memcg_limited_groups_array_size; > struct static_key memcg_kmem_enabled_key; > EXPORT_SYMBOL(memcg_kmem_enabled_key); > > +static void memcg_free_cache_id(int id); Any chance you could re-order this code to avoid the forward decl? memcg_alloc_cache_id() and memcg_free_cache_id() are new functions anyway, might as well put the definition above the callsites. Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
