On Friday 19 September 2014, Bjorn Helgaas wrote:
> On Thu, Sep 18, 2014 at 02:30:25AM +0100, Liviu Dudau wrote:
> PCI_IOBASE is a virtual address. So PCI_IOBASE + res->start is also a
> virtual address (only for IORESOURCE_IO).
>
> Since res->start is normally a *physical* address, I think it would be less
> confusing to do something like this:
>
> vaddr = PCI_IOBASE + res->start;
> ioremap_page_range(vaddr, vaddr + resource_size(res), ...);
>
> so we have a hint that the first two ioremap_page_range() parameters are
> virtual addresses. It's also confusing that it uses "unsigned long" for
> the virtual addresses, when we usually use "void *". But that's out of
> scope for this patch.
Good idea. I think it will have to be (unsigned long)PCI_IOBASE above then,
since ioremap_page_range takes a 'unsigned long' virtual address and PCI_IOBASE
should really remain an __iomem pointer.
Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
