On Fri, 2014-09-19 at 12:26 +0200, Javier Martinez Canillas wrote:
> The function max77686_rtc_calculate_wday() is used to
> calculate the day of the week to be filled in struct
> rtc_time but that function only calculates the number
> of bits shifted. So the ffs() function can be used to
> find the first bit set instead of a special function.
This isn't the same logic. Perhaps you want fls.
> diff --git a/drivers/rtc/rtc-max77686.c b/drivers/rtc/rtc-max77686.c
[]
> -static inline int max77686_rtc_calculate_wday(u8 shifted)
> -{
> - int counter = -1;
> - while (shifted) {
> - shifted >>= 1;
> - counter++;
> - }
> - return counter;
> -}
> -
> static void max77686_rtc_data_to_tm(u8 *data, struct rtc_time *tm,
> int rtc_24hr_mode)
> {
> @@ -93,7 +83,7 @@ static void max77686_rtc_data_to_tm(u8 *data, struct
> rtc_time *tm,
> tm->tm_hour += 12;
> }
>
> - tm->tm_wday = max77686_rtc_calculate_wday(data[RTC_WEEKDAY] & 0x7f);
> + tm->tm_wday = ffs(data[RTC_WEEKDAY] & 0x7f) - 1;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
