On Wed, Sep 17, 2014 at 05:47:57PM +0800, Ming Lei wrote: > Either the request is from requeue or just being allocated from > tag pool, its REQ_ATOM_STARTED flag has been cleared already, so > don't test it in blk_mq_start_request(). > > One memory barrier is needed between writing rq->deadline and > setting REQ_ATOM_STARTED so that timeout can't happen too early > if timeout handler reads obsolete rq->deadline caused by out > of order of the two writes.
Looks reasonable to me, Reviewed-by: Christoph Hellwig <h...@lst.de> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/