> > + if (pp->idx == 0 && > > + of_property_read_bool(port_np, "interrupt-controller")) { > > + pp->irq = irq_of_parse_and_map(port_np, 0); > > + if (!pp->irq) { > > + dev_warn(dev, "no irq for bank %s\n", > > + port_np->full_name); > > + } > > + } else { > > + pp->irq = 0; > > + } > > The else clause is not needed since pp->irq == 0 already, right? > Yes, while call kcalloc, the memory is set to '0'. I will improve it. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- [PATCH 0/4 v4] The Designware GPIO Supporting Weike Chen
- [PATCH 1/4 v4] GPIO: gpio-dwapb: Enable platform d... Weike Chen
- Re: [PATCH 1/4 v4] GPIO: gpio-dwapb: Enable pl... atull
- RE: [PATCH 1/4 v4] GPIO: gpio-dwapb: Enabl... Chen, Alvin
- [PATCH 4/4 v4] GPIO: gpio-dwapb: Suspend & Res... Weike Chen
- Re: [PATCH 4/4 v4] GPIO: gpio-dwapb: Suspend &... Andy Shevchenko
- RE: [PATCH 4/4 v4] GPIO: gpio-dwapb: Suspe... Chen, Alvin
- Re: [PATCH 4/4 v4] GPIO: gpio-dwapb: Suspend &... Shevchenko, Andriy
- [PATCH 3/4 v4] GPIO: gpio-dwapb: Support Debounce Weike Chen
- Re: [PATCH 3/4 v4] GPIO: gpio-dwapb: Support D... Andy Shevchenko
- RE: [PATCH 3/4 v4] GPIO: gpio-dwapb: Suppo... Chen, Alvin
- [PATCH 2/4 v4] GPIO: gpio-dwapb: Change readl&... Weike Chen